feat(blaze)!: remove legacy instance routes - #2585
Conversation
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
本次修改清晰区分 /v1/sandboxes 规范命名空间与 /v1/instances 兼容层,并收紧 warm pool 与重置路径的语义边界。以下三点建议供进一步确认:
reset接口在文档中声明“运行中实例返回 501 且不改变状态与资源”,建议在blazed层明确约束,以避免未来实现只重置部分资源时破坏兼容承诺。[pool]兼容配置仅接受旧版打包默认值,示例策略文件已移除该段,建议在 README 中强调任何手工[pool]修改都会被拒绝或忽略,以降低运维误用风险。storage_pool.quarantined当前始终为零且 warm pool 逻辑已移除,建议在设计文档中明确该字段仅用于报告暂时不可清理槽位,并提醒监控侧不要将其视作可用容量。
🤖 Generated by Qoder • View workflow run
a2579e7 to
e044518
Compare
|
@codex review Please review exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e044518dcb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
39f5d98 to
e46b17f
Compare
|
@codex review Please review exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e46b17f251
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e46b17f to
e0ebb10
Compare
|
@codex review Please review exact head |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
e0ebb10 to
6ddaa71
Compare
Expose lifecycle and guest operations only under /v1/sandboxes. Remove compatibility routing, long-lived documentation, and special rejection handling for the former /v1/instances namespace because Blaze has not been released with that contract. Remove the reset and placeholder checkpoint handlers together with their now-unused server-state accessors. Keep existing JSON field names and storage.instances_dir unchanged; they are not HTTP namespace compatibility. Checkpoint capture follows separately. Signed-off-by: Weisson <Weisson@linux.alibaba.com>
6ddaa71 to
8ec393c
Compare
|
@codex review Please review exact head |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Description
Blaze exposes sandbox lifecycle and guest operations only through
/v1/sandboxes.Blaze has not been released with a
/v1/instancescompatibility contract, so this change removes that HTTP namespace completely. Production routing contains no instance-namespace matcher or compatibility handler, and the long-lived documentation describes only the current sandbox routes. There is also no special regression test or response-precedence guarantee for the removed namespace; ordinary unregistered paths are handled by the server's general routing behavior.The supported routes are:
GET /v1/sandboxesPOST /v1/sandboxesGET /v1/sandboxes/{id}DELETE /v1/sandboxes/{id}POST /v1/sandboxes/{id}/execPOST /v1/sandboxes/{id}/readPOST /v1/sandboxes/{id}/writeAction-style reset, checkpoint, and destroy routes are not registered under the sandbox namespace. Canonical destruction remains
DELETE /v1/sandboxes/{id}. Checkpoint capture and listing are delivered separately by #2472.Existing JSON field names such as
instanceandinstance_id, and thestorage.instances_dirconfiguration key, remain unchanged because they describe data and storage rather than an HTTP namespace.The change also removes the incomplete reset handler, the placeholder checkpoint handler, and server-state accessors that became unused with those handlers. Strict Clippy verifies that the resulting production code has no warnings or dead-code allowances introduced by this change.
Behavior before
/v1/sandboxesand/v1/instances.Behavior after
/v1/sandboxesis the only documented and registered management namespace./v1/instances.Related issue
Closes #2577
Related checkpoint work: #2444, #2472
This pull request is based directly on current
mainand does not depend on #2293, #2296, or #2471.Type of Change
Scope
Testing
Revision identity
8ec393c95aed8fb12f02583af4d6634160272f2a35fe2a74cc8575b75b654a6a9fa673e882662aadmain:160297392b5f129dabd5accd6dd13214528832d5ce61858523bb1f527461429f7f7791f5a593dd46160297392b5f129dabd5accd6dd13214528832d5,8ec393c95aed8fb12f02583af4d6634160272f2a35fe2a74cc8575b75b654a6a9fa673e882662aadThe public head and GitHub merge candidate are byte-identical source trees.
Linux validation
Validated on Linux x86_64 with Rust and Cargo 1.88, locked dependencies, offline Cargo access, a fresh source tree, a fresh Cargo home, and separate empty target directories for every major stage:
cargo fmt --all -- --checkEvidence archive SHA-256:
b23a24206685304507a090bf770b1baca5abb9ca805c4c4e3b5510a821f1c9b4.Hosted Blaze, documentation, website, commit-message, pull-request metadata, component, and CLA checks passed for the exact head. Codex reviewed
8ec393c95aand found no major issues. This pull request is ready for maintainer review.Documentation
The English and Chinese Blaze README, user guide, and lifecycle design describe only the current
/v1/sandboxesAPI. No migration note or version-log entry is included because Blaze has not been released with the removed namespace.